Skip to content

OCPBUGS-34222: Fix for cypress local auth issue #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 28, 2024
Merged

OCPBUGS-34222: Fix for cypress local auth issue #13895

openshift-merge-bot merged 1 commit into from
May 28, 2024

Conversation

@nitin-dhevar
Copy link
Contributor

@nitin-dhevar nitin-dhevar commented May 23, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024

@nitin-dhevar: This pull request references Jira Issue OCPBUGS-34222, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett May 23, 2024 20:57
@openshift-ci openshift-ci bot added the component/backend Related to backend label May 23, 2024
@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented May 28, 2024 •
edited
Loading

/assign @jhadvig @TheRealJon

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@nitin-dhevar: GitHub didn't allow me to assign the following users: jonjacks.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @jhadvig @jonjacks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto
Copy link
Member

rhamilto commented May 28, 2024

Tested locally and confirmed tests now run. Thanks, @nitin-dhevar!

@rhamilto
Copy link
Member

rhamilto commented May 28, 2024

/retest

@rhamilto
Copy link
Member

rhamilto commented May 28, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2024

@rhamilto: This pull request references Jira Issue OCPBUGS-34222, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei May 28, 2024 14:47
@rhamilto rhamilto mentioned this pull request May 28, 2024
Merged
@rhamilto
Copy link
Member

rhamilto commented May 28, 2024

/assign @TheRealJon

TheRealJon
TheRealJon approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitin-dhevar, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2024

/retest-required

Remaining retests: 0 against base HEAD 821b63e and 2 for PR HEAD 8ca2824 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@nitin-dhevar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e1d700d into openshift:master May 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2024

@nitin-dhevar: Jira Issue OCPBUGS-34222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34222 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nitin-dhevar @openshift-ci-robot @rhamilto @TheRealJon @jhadvig